-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps engines #1
Maps engines #1
Conversation
Creating support for multiple map engines is a good idea. I'll go through the code later, but I've already got some comments:
Also note that my heightmap idea (based on the diamond-square algorithm) isn't working correctly yet, and may only work for the height generation step, and not the land generation (if we're following the same structure as the random map scripts in AoC, which we haven't decided yet). |
Your code looks fine, just a few last things:
|
engines: static: simple creates map with dirt diamondsquare: engine from detrumi mandelbrot: create map with mandelbrot set
It looks good now, so I merged it. (I accidentally merged it into detrumi:master instead of detrumi:random-maps, but I've fixed that afterwards) |
@timohaas depends on your intentions, but your pull requests will be visible to a much broader audience if you submit them to the root project directly. Of course i hope that detrumi will bring them upstream anyhow, but subforks are probably not that good, you'll also miss the CI builds then. |
created virtual class for map engines
engines: